New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call result.finalize to prevent memory leaks #7564
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
Thanks!
Is there an error you are running into? |
No, I just haven't set up my machine for JupyterLab development yet and I need to remember to update all the other tools that use embed. I can try to update the yarn.lock file later. |
No problem. Thanks for the PR! |
Tests are passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Unfortunately, I can't build jlab locally so I'm not updating Vega-Embed.
References
This pull request uses Vega-Embed 6.2's new finalize method.
Code changes
Calls
result.finalize
instead ofresult.view.finalize
.User-facing changes
Reduced memory usage.
Backwards-incompatible changes
None