Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call result.finalize to prevent memory leaks #7564

Merged
merged 5 commits into from Dec 12, 2019

Conversation

domoritz
Copy link
Member

Unfortunately, I can't build jlab locally so I'm not updating Vega-Embed.

References

This pull request uses Vega-Embed 6.2's new finalize method.

Code changes

Calls result.finalize instead of result.view.finalize.

User-facing changes

Reduced memory usage.

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout
Copy link
Contributor

Thanks!

Unfortunately, I can't build jlab locally so I'm not updating Vega-Embed.

Is there an error you are running into?

@domoritz
Copy link
Member Author

No, I just haven't set up my machine for JupyterLab development yet and I need to remember to update all the other tools that use embed. I can try to update the yarn.lock file later.

@jasongrout
Copy link
Contributor

No, I just haven't set up my machine for JupyterLab development yet and I need to remember to update all the other tools that use embed. I can try to update the yarn.lock file later.

No problem. Thanks for the PR!

@domoritz
Copy link
Member Author

domoritz commented Dec 5, 2019

Tests are passing.

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 92913c4 into jupyterlab:master Dec 12, 2019
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 11, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:vega status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants