New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storybook to ui-components #7588
Add storybook to ui-components #7588
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
3c79bac
to
eaa217e
Compare
89d9fbb
to
ed48150
Compare
I'm trying this out right now |
Had a heck of a time getting storybook to work with our own
Turned out there were two problems:
I fixed the I've also added a new story for the React version of our icons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! From my perspective, I think this PR is good to go. I'll add more stories as I go through and fix things in ui-components
(I have to rename a bunch of components as part of removing Blueprint and fixing icons anyway)
References
Fixes #6799
Storybook is an app that allows hot-reloading of components to enable fast iteration of design, especially for React components.
The included story imports the
@jupyterlab/light-theme-extension
so that a themed component can be created quickly.Code changes
Adds storybook infrastructure and a simple story to
ui-components
.User-facing changes
Backwards-incompatible changes