Allow platform aware key shortcuts #7589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normalizing keys will return a list of shortcuts available for the running platform (so platform specific keys + keys). Process that normalized list instead of the shortcut keys directly. This means that winKeys, linuxKeys, and macKeys are properly supported in jupyterlab shortcuts.
Phosphor allows shortcuts to be empty, and it’s the only way to have platform-specific shortcuts (define keys to be [], and the platform keys to be something specific). See phosphorjs/phosphor#438 for some discussion.
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
jasongrout
reviewed
Dec 4, 2019
jasongrout
reviewed
Dec 12, 2019
jasongrout
reviewed
Dec 12, 2019
jasongrout
approved these changes
Dec 23, 2019
There was a problem hiding this comment.
I merged in master to take care of conflicts, and tested once again. Looks good to me!
The Linux usage test failure looks like it is a Lumino issue that should be solved there, and looks like it is specific to the testing framework not running in an actual browser?
|
Thanks @jasongrout. |
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Supersedes #7581
Code changes
Relies on jupyterlab/lumino#11 to normalize key shortcuts before reconciling key shortcuts in jupyterlab.
Waiting on a new release of lumino before finishing this PR. I will comment below when ready for review. Thanks!
User-facing changes
Backwards-incompatible changes