Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect white background for new Command Palette Icon #7609

Merged
merged 1 commit into from Dec 10, 2019

Conversation

tgeorgeux
Copy link
Contributor

References

Fixes #7577 where Command Palette Icon renders with a white background

Code changes

None

User-facing changes

Fixes bug mentioned above.

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@tgeorgeux tgeorgeux changed the title Fixed incorrect white background Fixed incorrect white background for new Command Palette Icon Dec 10, 2019
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tgeorgeux
Copy link
Contributor Author

Forgot screenshots. Cannot show dark mode because of #7610

Screen Shot 2019-12-10 at 12 31 15 PM

@blink1073 blink1073 merged commit b349e5d into master Dec 10, 2019
@vidartf vidartf deleted the tgeorgeux-patch-2 branch December 11, 2019 15:36
@blink1073 blink1073 added this to the 2.0 milestone Jan 3, 2020
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 2, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants