Remove vega4-extension #7650
Merged
Remove vega4-extension #7650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 18, 2019 12:20
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
added 2 commits
December 18, 2019 13:17
telamonian
approved these changes
Dec 18, 2019
| }, | ||
| "devDependencies": { | ||
| "@types/node": "^12.12.17", |
There was a problem hiding this comment.
@blink1073 I was thinking through how to deal with this. Thanks for handling it!
I think there's an argument for getting rid of any explicit @types/node declaration, but I'll save that for another PR
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #7523
Code changes
Removes vega4-extension and updates vega5-extension to enable rendering vegalite-3 and vegalite-4 formats.
User-facing changes
Notebooks with vega output targeting older versions will render as pngs unless an additional vega4 extension is installed.
Backwards-incompatible changes
Drops direct support for rendering older vega formats.