Fix handling of code editor refresh #7672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
jasongrout
reviewed
Dec 23, 2019
packages/codeeditor/src/widget.ts
Outdated
| @@ -141,7 +141,7 @@ export class CodeEditorWrapper extends Widget { | |||
| * A message handler invoked on an `'after-show'` message. | |||
| */ | |||
| protected onAfterShow(msg: Message): void { | |||
| if (this._updateOnShow) { | |||
| if (this._updateOnShow || !this._hasRefreshed) { | |||
There was a problem hiding this comment.
It seems like this should be &&, not ||? Also, should _hasRefreshed be reset to false on hide?
There was a problem hiding this comment.
I updated the variable name and added a comment, as well as a reset whenever we attach.
There was a problem hiding this comment.
Thanks. That name change and comment made the logic clearer. I'll test.
jasongrout
approved these changes
Dec 23, 2019
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #7671
Code changes
Handles the case where a code editor is not visible when it tries to update. This can happen when the widget is attached and visible, and then is no longer visible when
onUpdateRequestis later called.User-facing changes
None in core JupyterLab, affects extension authors using code editors and things that depend on them (like notebooks).
Backwards-incompatible changes
None.