Update MathJax CDN in the cell and console examples #7680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
jtpio
force-pushed
the
examples-mathjax-cdn
branch
from
69561b8
to
1c34a4c
Compare
jasongrout
reviewed
Dec 23, 2019
examples/cell/index.html
Outdated
| @@ -2,11 +2,11 @@ | |||
| <html lang="en"> | |||
| <head> | |||
| <title>Cell Demo</title> | |||
| <script type="text/javascript" src="https://cdn.mathjax.org/mathjax/latest/MathJax.js?config=TeX-AMS_CHTML-full,Safe&delayStartupUntil=configured"></script> | |||
| <script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/mathjax/2.7.1/MathJax.js?config=TeX-AMS_CHTML-full,Safe&delayStartupUntil=configured"></script> | |||
There was a problem hiding this comment.
It looks like 2.7.7 is the latest 2.x release. Might as well move to the latest, if not to 3.0?
There was a problem hiding this comment.
OK to bump to 2.7.7 👍
For 3.0, maybe it could be done as part of #7218?
jtpio
force-pushed
the
examples-mathjax-cdn
branch
from
1c34a4c
to
1f13139
Compare
|
Thanks! |
jasongrout
approved these changes
Dec 23, 2019
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code changes
This fixes the following warning when running the
cellandconsoleexamples:This change updates the url for the CDN, following the recommendation from https://www.mathjax.org/cdn-shutting-down/.
User-facing changes
None
Backwards-incompatible changes
None