Be more careful about sessioncontext kernelChanged and sessionChanged signal emissions #7694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… signal emisssions Fixes jupyterlab#7690
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
…refresh. Before, the save would happen before the session was created, which meant that the args values would be undefined, so new consoles would be created on refresh, plus the existing sessions would be displayed, doubling the number of consoles every refresh. Fixes jupyterlab#7693
|
@blink1073 - this fixes some pretty bad bugs and I think should be in the next beta. |
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #7690 and #7693
Code changes
Emit the session and kernel changed signals when needed, like when the connection is disposed. Also use sessioncontext path/name for console tracker restoration.
User-facing changes
Fixes #7690, showing the kernel status correctly.
Backwards-incompatible changes
No APIs were changed.