TODO/Deprecations for 2.0

[jasongrout]

Searching the code base for TODO items or deprecations, I see some interesting possibilities:

I put each reference below in a checklist so that we can check off when we have examined it, and we can add a note or reference to an issue if we are solving it now.

Notes about TODO items

• jupyterlab/packages/filebrowser/src/listing.ts

  Line 1811 in 72d9e17

  // TODO: remove workaround if...else/code in else clause in v2.0.0

• jupyterlab/jupyterlab/handlers/extension_manager_handler.py

  Line 70 in 735dffc

  # TODO 2.0: Clean up signature to (self, app_options=None)

• jupyterlab/jupyterlab/handlers/extension_manager_handler.py

  Line 89 in 735dffc

  # TODO: Ensure loops can run in parallel

• jupyterlab/packages/statusbar/src/deprecated.tsx

  Line 8 in 6bc9df5

  TODO: delete this file in Jlab 2.0

• jupyterlab/jupyterlab/handlers/build_handler.py

  Line 25 in 735dffc

  # TODO 2.0: Clean up signature to (self, core_mode, app_options=None)

• jupyterlab/jupyterlab/extension.py

  Line 148 in 3d1e5ee

  # TODO: fix this when we can make such a change

• jupyterlab/packages/settingeditor/src/plugineditor.ts

  Line 48 in 7fb0185

  // TODO: Remove this layout. We were using this before when we

• jupyterlab/packages/notebook/src/panel.ts

  Line 166 in 72d9e17

  // TODO: do we still need to emit this signal? Who is using it?

• jupyterlab/packages/services/src/terminal/manager.ts

  Line 222 in dfeaf98

  // TODO: why do we care about resetting models if we are throwing right away?

• jupyterlab/packages/codemirror-extension/src/index.ts

  Line 351 in 7fb0185

  args: { ...spec } as any // TODO: Casting to `any` until lumino typings are fixed

• jupyterlab/packages/services/src/kernel/manager.ts

  Line 250 in dfeaf98

  // TODO: why do we care about resetting models if we are throwing right away?

• jupyterlab/packages/services/src/session/manager.ts

  Line 260 in dfeaf98

  // TODO: why do we care about resetting models if we are throwing right away?

• jupyterlab/packages/apputils/src/thememanager.ts

  Line 288 in 7fb0185

  // TODO: delete workaround in v2.0.0

• jupyterlab/packages/apputils/src/dialog.ts

  Line 68 in 72d9e17

  // TODO: Use .finally() above when supported

• jupyterlab/packages/apputils/src/dialog.ts

  Line 68 in 72d9e17

  // TODO: Use .finally() above when supported

• jupyterlab/packages/console-extension/src/index.ts

  Line 358 in 1fc7a3d

  // TODO: Lumino command functions should probably be allowed to return undefined?

Notes about deprecations

• jupyterlab/jupyterlab/labhubapp.py

  Line 35 in 3d710e0

  "SingleUserLabApp is deprecated, use SingleUserNotebookApp and set " + \

• jupyterlab/packages/services/src/kernel/messages.ts

  Lines 135 to 138 in 7fb0185

  	// Backwards compatibility workaround for services 4.0 defining the wrong
  	// comm_info_request content. This should be removed with the deprecated
  	// `target` content option in services 5.0. See
  	// https://github.com/jupyterlab/jupyterlab/issues/6947

• jupyterlab/tests/test-services/src/kernel/messages.spec.ts

  Line 173 in f2d664b

  // Tests deprecated option workaround. Should be deleted in services 5.0.

• jupyterlab/packages/rendermime/src/factories.ts

  Line 74 in 3755447

  * A placeholder factory for deprecated rendered JavaScript.

• jupyterlab/packages/rendermime/src/widgets.ts

  Line 382 in 72d9e17

  * A widget for displaying deprecated JavaScript output.

• jupyterlab/jupyterlab/commands.py

  Lines 347 to 364 in 5e68c8a

  	def _ensure_options(options, **kwargs):
  	"""Helper to use deprecated kwargs for AppOption"""
  	optClass = options.__class__ if issubclass(options.__class__, AppOptions) else AppOptions
  	# Filter out default-value kwargs
  	kwargs = dict(filter(lambda item: item[1] is not None, kwargs.items()))
  	# Warn for deprecated kwargs usage
  	if kwargs:
  	warnings.warn(
  	"Direct keyword args to jupyterlab.commands functions are "
  	"deprecated, use the options argument instead: %r" % (kwargs,),
  	DeprecationWarning)
  	if options is None:
  	return optClass(**kwargs)
  	# Also support mixed use of options and kwargs:
  	opt_args = {name: getattr(options, name) for name in options.trait_names()}
  	kwargs.update(**opt_args)
  	return optClass(**kwargs)

• jupyterlab/scripts/ci_script.sh

  Line 196 in 47de94a

  # Make sure the deprecated `selenium_check` command still works

[jasongrout]

@blink1073 - here are some possibly api-breaking changes we've held off on for 2.0. Do you (or anyone else) have time to look at these to decide whether we really want to do them for 2.0?

[blink1073]

I'm making a PR now, checking off items as I address them.

[telamonian]

I checked off the one from jupyterlab/packages/filebrowser/src/listing.ts, that's handled by #7700. I'll probably also handle deleting jupyterlab/packages/statusbar/src/deprecated.tsx in that same PR

[blink1073]

I already removed jupyterlab/packages/statusbar/src/deprecated.tsx in my branch.

[jasongrout]

I should add here that the source links above were from looking at the TODO and deprecation search results linked above and trying to filter them for 2.0-relevant issues. If someone has time to look at the full list of search results to double-check that I didn't miss anything relevant, that would be great.

[blink1073]

@telamonian, I see that you would pick up merge conflicts in #7700 if I remove deprecated.tsx, I'll restore it here.

[blink1073]

Closing as addressed by #7724 and #7700, at least as far as 2.0-readiness is concerned.