Address todos and deprecations for 2.0 #7724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
blink1073
changed the title
|
@jasongrout, are you able to review this one? |
|
@telamonian, same question. I'd like to include this in the beta today. |
|
I can review this tomorrow, but not today. |
|
(I'm happy to do the beta release tomorrow as well, if it turns out that I need to review this tomorrow) |
telamonian
approved these changes
Jan 4, 2020
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Partially addresses #7720
Code changes
Remove deprecations and implement some TODOs for 2.0.
User-facing changes
None
Backwards-incompatible changes
Some deprecation warnings are implemented. The signature of our
commandsfunctions has been simplified.