New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lumino dependencies #7763
Update lumino dependencies #7763
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
We should also switch to |
1024ad1
to
b6b7284
Compare
This appears to be working, but I see a split-second huge flash of the launcher icon every time I load/reload the page. I don't know if this is caused by the CSS changes in this PR or if it exists in I will investigate later today. If anybody has seen what I'm talking about in another branch, please mention it. |
I asked about that flash in the dev meeting a week or two ago. Max said he
knew what the problem was, that the svg icons had the wrong intrinsic
sizes. Tim said he would also look at it.
|
Thanks Jason, good to know. This is ready for review then. It's 👍 from
me but I added my own changes to it.
…On Wed, 15 Jan 2020 at 12:53 Jason Grout ***@***.***> wrote:
I asked about that flash in the dev meeting a week or two ago. Max said he
knew what the problem was, that the svg icons had the wrong intrinsic
sizes. Tim said he would also look at it.
On Wed, Jan 15, 2020 at 1:37 PM Afshin Taylor Darian <
***@***.***> wrote:
> This appears to be working, but I see a split-second huge flash of the
> launcher icon every time I load/reload the page. I don't know if this is
> caused by the CSS changes in this PR or if it exists in master.
>
> I will investigate later today. If anybody has seen what I'm talking
about
> in another branch, please mention it.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <
#7763?email_source=notifications&email_token=AABPAZRXL2PM2NW4S2O3U3DQ537O7A5CNFSM4KE3BRWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJAFIZQ#issuecomment-574641254
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AABPAZVJDPIUJUB6Z2OPQ4LQ537O7ANCNFSM4KE3BRWA
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#7763?email_source=notifications&email_token=AABG6KLCLX2TXU7RGAFCHODQ54BK7A5CNFSM4KE3BRWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJAGVLA#issuecomment-574646956>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABG6KMJTJVTYP5LNQDAJATQ54BK7ANCNFSM4KE3BRWA>
.
|
References
Fixes #7762
Code changes
Bump lumino dependencies to latest to allow extension authors to switch to the new
lm-
or continue to usep-
selectors if desired.User-facing changes
None
Backwards-incompatible changes
None