Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lumino dependencies #7763

Merged
merged 5 commits into from Jan 15, 2020

Conversation

blink1073
Copy link
Member

References

Fixes #7762

Code changes

Bump lumino dependencies to latest to allow extension authors to switch to the new lm- or continue to use p- selectors if desired.

User-facing changes

None

Backwards-incompatible changes

None

@blink1073 blink1073 added this to the 2.0 milestone Jan 9, 2020
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout
Copy link
Contributor

We should also switch to lm- as an example, right?

@afshin
Copy link
Member

afshin commented Jan 15, 2020

This appears to be working, but I see a split-second huge flash of the launcher icon every time I load/reload the page. I don't know if this is caused by the CSS changes in this PR or if it exists in master.

I will investigate later today. If anybody has seen what I'm talking about in another branch, please mention it.

@jasongrout
Copy link
Contributor

jasongrout commented Jan 15, 2020 via email

@afshin
Copy link
Member

afshin commented Jan 15, 2020 via email

@blink1073 blink1073 merged commit d322d6b into jupyterlab:master Jan 15, 2020
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 14, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 14, 2020
@blink1073 blink1073 deleted the update-lumino-packages branch March 29, 2020 10:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow extension authors to use lm- prefix or p-
3 participants