Changes to setting editor should trigger application dirty state #7774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirty state Fixes jupyterlab#7757
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #7757
Code changes
In
settingEditorextension, when the status of the commands (revert, save) change, I check if the editor has unsaved changes (using the property editor.canSaveRaw). If this is set totrue,LabStatus.setDIrtyis invoked. If set tofalse, the dirty status is cleared.User-facing changes
Closing / reloading lab when there are unsaved changes in the settings editor would warn of unsaved changes and ask if the user should .