Fix lint-staged for both win and mac #7784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
I don't understand this Windows failure. It seems to fail repeatedly on the Any idea what is happening? Perhaps if you rebase and it is pulling something different it might get past that? |
telamonian
force-pushed
the
fix-win-lint-staged
branch
from
ba3bcf3
to
a530434
Compare
Rebase done (feels a bit like fiddling with the antenna on a tv). We'll see if that resolves the weird checkout problem |
|
Seems to work locally. Thanks! |
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
0bdce26
#7708
lint-staged/lint-staged#676 (comment)
https://github.com/zeit/next.js/blob/canary/lint-staged.config.js
Code changes
Changed the lint-staged config from a json file to a js script. This is to fix an ongoing back and forth in which said config is broken w.r.t. to exactly one of mac and windows.
@vidartf I've tested this PR on mac. Can you please test this out for me on Windows?
User-facing changes
NA
Backwards-incompatible changes
NA