Give kernel connection options to a session connection #7820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now this is just handleComms, but it may grow in the future.
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
jasongrout
changed the title
|
@blink1073 - this may solve jupyter-widgets/ipywidgets#2748, so it may be good to get in to the RC if it passes review. |
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This may help with jupyter-widgets/ipywidgets#2748
Code changes
Adds optional kernel connection options to a session connection, so (for now) you can say you want kernel connections that do not handle comms.
User-facing changes
None
Backwards-incompatible changes
This is backwards compatible because it introduces an optional argument.