Fix unexpected jump to last search result when using documentsearch #7835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
Thank you, Marisa! |
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This is a fix to issue #7476: adding or deleting cells while using documentsearch unexpectedly jumps to the last result of the query.
Code changes
The jumping behavior was originally an intentional feature, but one that contradicts expected behavior of documentsearch. I have removed
_restartQuery()and modified functions supporting this feature in notebooksearchprovider.ts.User-facing changes
This fix allows users to continue working in their current spot after adding or deleting cells while keeping the document search box open. To proceed to the next search result, users can press enter within the search box as expected.
Backwards-incompatible changes
None