From a42906999da1b1a05a92d74d8fca0e539f31c1c6 Mon Sep 17 00:00:00 2001 From: Marisa Aquilina Date: Thu, 23 Jan 2020 18:15:56 -0800 Subject: [PATCH 1/2] Resolve unexpected jump issue --- Untitled.ipynb | 6 ++++++ .../src/providers/notebooksearchprovider.ts | 12 ------------ 2 files changed, 6 insertions(+), 12 deletions(-) create mode 100644 Untitled.ipynb diff --git a/Untitled.ipynb b/Untitled.ipynb new file mode 100644 index 000000000000..7fec51502cbc --- /dev/null +++ b/Untitled.ipynb @@ -0,0 +1,6 @@ +{ + "cells": [], + "metadata": {}, + "nbformat": 4, + "nbformat_minor": 4 +} diff --git a/packages/documentsearch/src/providers/notebooksearchprovider.ts b/packages/documentsearch/src/providers/notebooksearchprovider.ts index 7a7b85ef2b34..fe2e0144a32b 100644 --- a/packages/documentsearch/src/providers/notebooksearchprovider.ts +++ b/packages/documentsearch/src/providers/notebooksearchprovider.ts @@ -60,15 +60,10 @@ export class NotebookSearchProvider implements ISearchProvider { this._searchTarget = searchTarget; const cells = this._searchTarget.content.widgets; - this._query = query; this._filters = !filters || Object.entries(filters).length === 0 ? { output: true } : filters; - // Listen for cell model change to redo the search in case of - // new/pasted/deleted cells - const cellList = this._searchTarget.model!.cells; - cellList.changed.connect(this._restartQuery.bind(this), this); // hide the current notebook widget to prevent expensive layout re-calculation operations this._searchTarget.hide(); @@ -461,12 +456,6 @@ export class NotebookSearchProvider implements ISearchProvider { return match; } - private async _restartQuery() { - await this.endQuery(); - await this.startQuery(this._query, this._searchTarget!, this._filters); - this._changed.emit(undefined); - } - private _getMatchesFromCells(): ISearchMatch[][] { let indexTotal = 0; const result: ISearchMatch[][] = []; @@ -503,7 +492,6 @@ export class NotebookSearchProvider implements ISearchProvider { } private _searchTarget: NotebookPanel | undefined | null; - private _query: RegExp; private _filters: INotebookFilters; private _searchProviders: ICellSearchPair[] = []; private _currentProvider: ICellSearchPair | null | undefined; From a0d234a1f6a503e7e02f0a5d2504f148baf6d93d Mon Sep 17 00:00:00 2001 From: Marisa Aquilina Date: Thu, 23 Jan 2020 18:20:31 -0800 Subject: [PATCH 2/2] RemoveUntitled notebook --- Untitled.ipynb | 6 ------ 1 file changed, 6 deletions(-) delete mode 100644 Untitled.ipynb diff --git a/Untitled.ipynb b/Untitled.ipynb deleted file mode 100644 index 7fec51502cbc..000000000000 --- a/Untitled.ipynb +++ /dev/null @@ -1,6 +0,0 @@ -{ - "cells": [], - "metadata": {}, - "nbformat": 4, - "nbformat_minor": 4 -}