Add password dialog to apputils #7855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
vidartf
approved these changes
Feb 6, 2020
vidartf
reviewed
Feb 6, 2020
| /** | ||
| * Widget body for input password dialog | ||
| */ | ||
| class InputPasswordDialog extends InputDialogBase<string> { |
There was a problem hiding this comment.
Would it be simpler to just inherit InputTextDialog ?
There was a problem hiding this comment.
I don't think that it would change the length of the code. The boolean input dialog is also basically the same. All that differ is the constructor.
SylvainCorlay
force-pushed
the
PasswordDialog
branch
from
f391414
to
5d70f55
Compare
|
How about adding it to the "User Interface Helpers" docs as well? https://jupyterlab.readthedocs.io/en/latest/developer/ui_helpers.html#input-dialogs |
Just added an example. |
|
Any chances of getting this in? |
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code changes
Adding a password dialog to AppUtil.
This is something that I used for an extension (and required duplicating some JupyterLab code). This is much simpler this way.
Backwards-incompatible changes
None