Make IFuture done typings more correct #8032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kernel IFuture done promise never returns undefined in practice (since every shell/control message has a reply, which is needed for the done promise to even resolve), so we strengthen the typing in the interface. This means that things relying on the done resolution do not have to check to see if the value is undefined from a typing perspective.
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
(note that strictly speaking this does qualify as backwards incompatible) |
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Code changes
The kernel IFuture done promise never returns undefined in practice (since every shell/control message has a reply, which is needed for the done promise to even resolve), so we strengthen the typing in the interface.
This means that things relying on the done resolution do not have to check to see if the value is undefined from a typing perspective.
User-facing changes
Backwards-incompatible changes