Fix cell execution when recording timing #8057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returning false prevents the message from being processed by the future or by any other hook, which messes everything up. Fixes jupyterlab#8056
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
This is definitely a 2.0.x bugfix. |
|
CC @saulshanabrook - can you review this? |
|
Works for me! Thanks @jasongrout and @aquirdTurtle for reporting! |
jasongrout
added a commit
to jasongrout/jupyterlab-execute-time
that referenced
this pull request
Apr 8, 2020
There was a bug in JLab 2.0.0 and 2.0.1 that prevented cell execution when recordTiming was enabled. You might be able to cut down on support issues if you just go ahead and require at least JLab 2.0.2. See jupyterlab/jupyterlab#8057 and jupyterlab/jupyterlab#8056
mlucool
pushed a commit
to deshaw/jupyterlab-execute-time
that referenced
this pull request
Apr 9, 2020
There was a bug in JLab 2.0.0 and 2.0.1 that prevented cell execution when recordTiming was enabled. You might be able to cut down on support issues if you just go ahead and require at least JLab 2.0.2. See jupyterlab/jupyterlab#8057 and jupyterlab/jupyterlab#8056
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #8056
Code changes
The recordTiming future message hook should always return true.
Returning false prevents the message from being processed by the future or by any other hook, which messes everything up.
User-facing changes
Backwards-incompatible changes