New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use tree/table buttons to display debugger variables view mode #9502
Use tree/table buttons to display debugger variables view mode #9502
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
This is a great choice @karlaspuldaro. Thanks for doing this work! |
I think using toggle buttons over a mode switch looks great. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @karlaspuldaro! This is great 👍
Thanks it looks great! Looks like it might need an integrity fix, but otherwise it looks good 👍 |
@jtpio integrity was verified locally. Any chance the failure is coming from the warnings in unchanged files? |
@karlaspuldaro I think it was because the integrity script checks the new icons are also in Just pushed a change to the branch that should fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
References
Implements enhancement described in #9425
Code changes
Remove the toggle switch for variables view mode and replace it with buttons representing tree/table views, making the button role more visually clear to the user