Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tree/table buttons to display debugger variables view mode #9502

Merged
merged 5 commits into from Jan 6, 2021

Conversation

karlaspuldaro
Copy link
Contributor

References

Implements enhancement described in #9425

Code changes

Remove the toggle switch for variables view mode and replace it with buttons representing tree/table views, making the button role more visually clear to the user

debugger-variables-UI

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@github-actions github-actions bot added Design System CSS pkg:debugger pkg:ui-components tag:CSS For general CSS related issues and pecadilloes labels Dec 23, 2020
@afshin afshin self-requested a review December 23, 2020 17:15
@jasongrout jasongrout added this to the 3.1 milestone Dec 23, 2020
@isabela-pf
Copy link
Contributor

This is a great choice @karlaspuldaro. Thanks for doing this work!

@jasongrout
Copy link
Contributor

I think using toggle buttons over a mode switch looks great. Thanks!

Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @karlaspuldaro! This is great 👍

@jtpio
Copy link
Member

jtpio commented Jan 5, 2021

Thanks it looks great!

Looks like it might need an integrity fix, but otherwise it looks good 👍

@karlaspuldaro
Copy link
Contributor Author

@jtpio integrity was verified locally. Any chance the failure is coming from the warnings in unchanged files?

@jtpio
Copy link
Member

jtpio commented Jan 6, 2021

@karlaspuldaro I think it was because the integrity script checks the new icons are also in deprecated.css.

Just pushed a change to the branch that should fix it.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 7050927 into jupyterlab:master Jan 6, 2021
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Oct 21, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Design System CSS pkg:debugger pkg:ui-components status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:CSS For general CSS related issues and pecadilloes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants