Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move open_browser to the top level configs of classes. #9580

Merged
merged 1 commit into from Jan 9, 2021

Conversation

jasongrout
Copy link
Contributor

References

Fixes #9579

See jupyter-server/jupyter_server#375

Code changes

This follows on changes to Jupyter Server and ExtensionApp which moves open_browser to the ExtensionApp config.

User-facing changes

Backwards-incompatible changes

This follows on changes to Jupyter Server and ExtensionApp which moves open_browser to the ExtensionApp config.

See jupyter-server/jupyter_server#375

Fixes jupyterlab#9579
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout jasongrout added this to the 3.0 milestone Jan 8, 2021
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit df5bb25 into jupyterlab:master Jan 9, 2021
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jul 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser Check is Incorrectly Launching a Browser
2 participants