Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Remove temporary fix from crates/router/src/core/payments/flows/psync_flow.rs #4644

Open
2 tasks done
deepanshu-iiitu opened this issue May 14, 2024 · 0 comments
Open
2 tasks done
Assignees
Labels
A-connector-integration Area: Connector integration A-core Area: Core flows C-feature Category: Feature request or enhancement

Comments

@deepanshu-iiitu
Copy link
Contributor

deepanshu-iiitu commented May 14, 2024

Feature Description

A temporary fix was added in crates/router/src/core/payments/flows/psync_flow.rs while moving struct RouterData out from crate router(#4524). This temporary fix needs to be removed after moving all the router data flows to new crate hyperswitch_connectors.

Possible Implementation

The clone on router data needs to be removed after removing the function execute_connector_processing_step_for_each_capture as an impl on trait RouterDataPSync.

Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

Yes, I am willing to submit a PR!

@deepanshu-iiitu deepanshu-iiitu added A-connector-integration Area: Connector integration A-core Area: Core flows C-feature Category: Feature request or enhancement labels May 14, 2024
@deepanshu-iiitu deepanshu-iiitu self-assigned this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration A-core Area: Core flows C-feature Category: Feature request or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant