Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundleDependencies option is breaking migration to v15 for @angular-builders/custom-webpack:server #1340

Closed
DzmVasileusky opened this issue Feb 9, 2023 · 4 comments

Comments

@DzmVasileusky
Copy link

Describe the Bug

After updating to 15th version build process managed by @angular-builders/custom-webpack:server is throwing 'bundleDependencies' is not found in schema error.
But migration guide says:

No breaking changes (except for updating to Angular 15)

It seems bundleDependencies is a breaking change.

Minimal Reproduction

"server": {
      "executor": "@angular-builders/custom-webpack:server",
      "options": {
        "bundleDependencies": true,
        "customWebpackConfig": {
          "path": ".../webpack.server.config.js"
        },
        "main": "...",
        "optimization": true,
        "outputHashing": "media",
        "outputPath": "...r",
        "sourceMap": false,
        "stylePreprocessorOptions": {
          "includePaths": [...]
        },
        "tsConfig": "..."
      },
      "configurations": {
        "dev": {
          "fileReplacements": [
            {
              "replace": "...",
              "with": "..."
            }
          ]
        },
        "proto1": {
          "fileReplacements": [
            {
              "replace": "...",
              "with": "..."
            }
          ]
        },
        "proto2": {
          "fileReplacements": [
            {
              "replace": "...",
              "with": "..."
            }
          ]
        },
        "proto3": {
          "fileReplacements": [
            {
              "replace": "...",
              "with": "..."
            }
          ]
        },
        "staging": {
          "fileReplacements": [
            {
              "replace": "...",
              "with": "..."
            }
          ]
        },
        "production": {
          "fileReplacements": [
            {
              "replace": "...",
              "with": "..."
            }
          ]
        }
      }
    },

Expected Behavior

No error or clear migration guide about breaking changes.

Environment


Libs
- @angular/core version: 15.1.4
- @angular-devkit/build-angular version: 15.1.5
- @angular-builders/custom-webpack version: 15.0.0

For Tooling issues:
- Node version: v16.15.0
- Platform:  Mac
@DzmVasileusky
Copy link
Author

So I have investigated it a little bit and the problem is that automatic angular/nx migration tools isn't updating @angular-builders/custom-webpack:server config.
So since bundleDependencies was just true by default it can be just removed.
Not sure if it is needed to be inside migration guide.

@arturovt
Copy link
Collaborator

arturovt commented Mar 1, 2023

They don't allow having our builder in migration code and I'm sure they won't. What you should do before migrations is change the @angular-builders/custom-webpack to @angular-devkit/build-angular, then run nx migrate --run-migrations and then revert builders.

@arturovt arturovt closed this as completed Mar 1, 2023
@just-jeb
Copy link
Owner

just-jeb commented Mar 1, 2023

#1342 Duplicate?

@arturovt
Copy link
Collaborator

arturovt commented Mar 1, 2023

Yeah, definitely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants