Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#61 move react-hot-loader to dependencies #65

Closed
wants to merge 1 commit into from

Conversation

mahboubii
Copy link

fixes #61

@JohnHeitmann
Copy link

react-hot-loader shouldn't be a full dependency. Based on some local testing, I think if @justinmc rebuilds with an updated dependency tree then babel (or whatever was doing it) will no longer add the react-hot-loader require into bundle.js; no source changes are required.

Alternately, removing react-hot-loader entirely could be appropriate. I'm not sure why it's here in the first place.

@OnkelTem
Copy link

Since when adding a dev module to prod deps is reckoned a fix? Sorry.

@mahboubii
Copy link
Author

@OnkelTem you're right i didn't dig into the issue and source code to actually fix the problem, this is just to fix the build error.

@mahboubii mahboubii closed this Feb 20, 2020
@mahboubii mahboubii deleted the patch-2 branch February 20, 2020 08:00
@AshotN
Copy link

AshotN commented Feb 25, 2020

Is there plans to remove it fully? There hasn't been a release to NPM for a while and I just ran into this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot find module react-hot-loader in version 0.11.1
5 participants