Skip to content

Commit

Permalink
Merge pull request #273 from dmitry-varennikov-eventbase/uri-retrieve…
Browse files Browse the repository at this point in the history
…r-error-handler-2

Throw `ResourceNotFoundException` outside of re-defined error-handler
  • Loading branch information
bighappyface committed Jun 2, 2016
2 parents e2bea02 + 534f66d commit 6b2a33e
Showing 1 changed file with 18 additions and 18 deletions.
36 changes: 18 additions & 18 deletions src/JsonSchema/Uri/Retrievers/FileGetContents.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,51 +14,51 @@

/**
* Tries to retrieve JSON schemas from a URI using file_get_contents()
*
* @author Sander Coolen <sander@jibber.nl>
*
* @author Sander Coolen <sander@jibber.nl>
*/
class FileGetContents extends AbstractRetriever
{
protected $messageBody;

/**
* {@inheritDoc}
* @see \JsonSchema\Uri\Retrievers\UriRetrieverInterface::retrieve()
*/
public function retrieve($uri)
{
$context = stream_context_create(array(
'http' => array(
'method' => 'GET',
'header' => "Accept: " . Validator::SCHEMA_MEDIA_TYPE
)));

set_error_handler(function() use ($uri) {
throw new ResourceNotFoundException('JSON schema not found at ' . $uri);
$errorMessage = null;
set_error_handler(function ($errno, $errstr) use (&$errorMessage) {
$errorMessage = $errstr;
});
$response = file_get_contents($uri);
restore_error_handler();

if ($errorMessage) {
throw new ResourceNotFoundException($errorMessage);
}

if (false === $response) {
throw new ResourceNotFoundException('JSON schema not found at ' . $uri);
throw new ResourceNotFoundException('JSON schema not found at '.$uri);
}

if ($response == ''
&& substr($uri, 0, 7) == 'file://' && substr($uri, -1) == '/'
) {
throw new ResourceNotFoundException('JSON schema not found at ' . $uri);
throw new ResourceNotFoundException('JSON schema not found at '.$uri);
}

$this->messageBody = $response;
if (! empty($http_response_header)) {
if (!empty($http_response_header)) {
$this->fetchContentType($http_response_header);
} else {
// Could be a "file://" url or something else - fake up the response
$this->contentType = null;
}

return $this->messageBody;
}

/**
* @param array $headers HTTP Response Headers
* @return boolean Whether the Content-Type header was found or not
Expand All @@ -70,10 +70,10 @@ private function fetchContentType(array $headers)
return true;
}
}

return false;
}

/**
* @param string $header
* @return string|null
Expand Down

0 comments on commit 6b2a33e

Please sign in to comment.