Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Problem with items being an array of schema #521

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bugfix: Problem with items being an array of schema #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ad06ab
Add a failing test about items being an array
wlalele Jul 2, 2018
5bd5ac3
Fix default value, with an array of item schemas
alex-pex Jul 2, 2018
079f529
Move and set a real number to the new test
wlalele Jul 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/JsonSchema/Constraints/UndefinedConstraint.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,8 +280,8 @@ protected function applyDefaultValues(&$value, $schema, $path)
} else {
$value[$currentItem] = $itemDefinition->default;
}
$path->setFromDefault();
}
$path->setFromDefault();
}
} elseif (
$value instanceof self
Expand Down
5 changes: 5 additions & 0 deletions tests/Constraints/DefaultPropertiesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,11 @@ public function getValidTests()
'{"items":{"default":"b"}, "minItems": 3}',
'["a","b","b"]'
),
array(// #24 items is an array of schema
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves #521 (review)

'[{}]',
'{"items":[{"properties":{"propertyOne":{"default":"valueOne"}}}]}',
'[{"propertyOne":"valueOne"}]'
),
);
}

Expand Down