Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PHP 8 function signature fixes to 5.x.x branch #626

Closed
wants to merge 1 commit into from
Closed

Backport PHP 8 function signature fixes to 5.x.x branch #626

wants to merge 1 commit into from

Commits on Apr 4, 2020

  1. Fix PHP 8 deprecation notices on required parameters appearing after … 

    …optional parameters.

This is related to #619, where the fix was applied on the master branch. This commit backports them to 5.x.x branch.
From PHP 8.0 and forwards, a deprecation notice is raised if there are required parameters after optional parameters in a function/method signature.
See https://php.watch/versions/8.0/deprecate-required-param-after-optional for details.
    @Ayesh
    Ayesh committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    457d152 View commit details
    Browse the repository at this point in the history