Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type validation failing for "any" and false-y type wording #686

Conversation

Deuchnord
Copy link
Contributor

Fixing a small issue that makes type validation fail when type is any or a false-y value, due to isset() returning false for null variables.

@Deuchnord Deuchnord force-pushed the fix/validateTypeNameWording-null-values branch from 9348929 to dfb0a87 Compare April 5, 2022 13:28
@Deuchnord Deuchnord changed the base branch from master to 5.x.x April 5, 2022 13:28
@Deuchnord Deuchnord force-pushed the fix/validateTypeNameWording-null-values branch from dfb0a87 to 573e21e Compare April 6, 2022 09:22
@Seldaek Seldaek added the Bug label Apr 6, 2022
@Seldaek
Copy link
Collaborator

Seldaek commented Apr 6, 2022

This should be rebased on master actually, and then we do a backport to 5.x.x branch from master. Fix looks good to me though.

@Deuchnord Deuchnord force-pushed the fix/validateTypeNameWording-null-values branch from 573e21e to 03a5d22 Compare April 6, 2022 12:06
@Deuchnord Deuchnord changed the base branch from 5.x.x to master April 6, 2022 12:07
@Seldaek Seldaek merged commit 726a706 into justinrainbow:master Apr 13, 2022
@Deuchnord Deuchnord deleted the fix/validateTypeNameWording-null-values branch April 13, 2022 07:39
@Deuchnord Deuchnord restored the fix/validateTypeNameWording-null-values branch April 13, 2022 07:39
@Seldaek
Copy link
Collaborator

Seldaek commented Apr 13, 2022

Released as 5.2.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants