Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate unique strings for screenshots #46

Open
justinsacbibit opened this issue May 21, 2016 · 0 comments
Open

Generate unique strings for screenshots #46

justinsacbibit opened this issue May 21, 2016 · 0 comments

Comments

@justinsacbibit
Copy link
Owner

justinsacbibit commented May 21, 2016

Screenshot URLs currently use auto-incrementing IDs, e.g. https://trucksu.com/ss/2. This means that essentially all screenshots uploaded are easily accessible by anyone.

Instead, we should use a unique string for each screenshot. However, we have to decide what happens with existing screenshots - if we change them to use the unique string, then the existing links to them will be dead, and the user will also not know how to access them.

A couple of potential solutions to the above problem:

  1. give a user access to their screenshots on the website
  2. don't generate unique strings for existing screenshots, just keep them accessible through their IDs

Right now, I think that a good idea would be to go with the second option listed above. Then, we eventually implement the first option, and then convert existing screenshots to use unique strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant