Do not block while waiting for previous message to be confirmed #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before ChannelWrapper would always wait for a message to be confirmed before publishing the next message. This commit changes the behaviour so messages are published to the lower level channel as fast as they are received by the ChannelWrapper.
3 similar comments
jwalton
approved these changes
May 1, 2019
| return sendPromise; | ||
| }) | ||
| .then( | ||
| result => { | ||
| this._messages.shift(); | ||
| this._unconfirmedMessages.shift(); |
There was a problem hiding this comment.
This assumes messages will be confirmed in the same order they were added to _unconfirmedMessages, but that sounds reasonable.
|
This should fix #65, too. |
|
Oops - didn't realize your commit message didn't conform to angular commit style - no build was kicked off for this. |
jwalton
pushed a commit
that referenced
this pull request
May 21, 2019
|
🎉 This PR is included in version 2.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before ChannelWrapper would always wait for a message to be confirmed before publishing the next message. This commit changes the behaviour so messages are published to the lower level channel as fast as they are received by the ChannelWrapper.
This means that for code like this, all messages will by published at once, instead of waiting for each message to be confirmed before publishing the next: