From e3a7ff6e332c85f2dcb43d743c75051bd7e00d0b Mon Sep 17 00:00:00 2001 From: Joe Natalzia Date: Mon, 23 Mar 2020 12:46:07 -0400 Subject: [PATCH] Set importsNotUsedAsValues --- src/js/controller/async-item.ts | 4 ++-- src/js/program/shared-media-pool.ts | 2 +- src/js/utils/defaults.ts | 2 +- src/js/view/controls/templates/slider.ts | 2 +- tsconfig.json | 3 ++- 5 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/js/controller/async-item.ts b/src/js/controller/async-item.ts index df0d26377f..a8a1226f80 100644 --- a/src/js/controller/async-item.ts +++ b/src/js/controller/async-item.ts @@ -1,8 +1,8 @@ import { normalizePlaylistItem } from 'playlist/playlist'; // Type only imports import Item from 'playlist/item'; -import Model from 'controller/model'; -import ApiPublic from 'api/api'; +import type Model from 'controller/model'; +import type ApiPublic from 'api/api'; type AsyncCallback = (item: Item, index: number) => Promise | void; diff --git a/src/js/program/shared-media-pool.ts b/src/js/program/shared-media-pool.ts index 83529578e4..12ec351070 100644 --- a/src/js/program/shared-media-pool.ts +++ b/src/js/program/shared-media-pool.ts @@ -1,4 +1,4 @@ -import { MediaElementPoolInt } from 'program/media-element-pool'; +import type { MediaElementPoolInt } from 'program/media-element-pool'; export default function SharedMediaPool(sharedElement: HTMLVideoElement, mediaPool: MediaElementPoolInt): MediaElementPoolInt { return Object.assign({}, mediaPool, { diff --git a/src/js/utils/defaults.ts b/src/js/utils/defaults.ts index 1b7048e249..9f00f16cac 100644 --- a/src/js/utils/defaults.ts +++ b/src/js/utils/defaults.ts @@ -1,4 +1,4 @@ -import { GenericObject } from '../types/generic.type'; +import type { GenericObject } from '../types/generic.type'; // Adds properties to the first object from the rest // Does not add properties which exist anywhere in the object or it's prototype chain (no shadowing, no overriding) diff --git a/src/js/view/controls/templates/slider.ts b/src/js/view/controls/templates/slider.ts index 87142b8d68..c448384bc2 100644 --- a/src/js/view/controls/templates/slider.ts +++ b/src/js/view/controls/templates/slider.ts @@ -1,4 +1,4 @@ -import { HTMLTemplateString } from 'types/generic.type'; +import type { HTMLTemplateString } from 'types/generic.type'; export default (className = '', orientation = ''): HTMLTemplateString => { return ( diff --git a/tsconfig.json b/tsconfig.json index cb4c21370b..e6da0125f7 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -8,7 +8,8 @@ "noImplicitThis": true, "noUnusedLocals": true, "strictPropertyInitialization": true, - "noEmit": true + "noEmit": true, + "importsNotUsedAsValues": "error" }, "include": [ "src/js"