Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Clock in favor of Supplier<Date> #352

Open
lhazlewood opened this issue Jul 17, 2018 · 2 comments
Open

Remove Clock in favor of Supplier<Date> #352

lhazlewood opened this issue Jul 17, 2018 · 2 comments
Labels
jdk8 Changes related to migrating to JDK8 API features
Milestone

Comments

@lhazlewood
Copy link
Contributor

Requires JDK 8, i.e. 1.0.0 release #java

@lhazlewood lhazlewood added this to the 1.0 milestone Jul 17, 2018
@lhazlewood lhazlewood changed the title Remove Clock in favor of Supplier<Date> for 1.0 Remove Clock in favor of Supplier<Date> Jul 17, 2018
@virtual-machinist
Copy link

virtual-machinist commented Sep 9, 2019

Why not Supplier<Instant> then? Seems there are multiple issues that propose moving to java.time classes. However the wording still doesn't make much sense - if we have to use java.util.function.Supplier available since Java 8, we don't introduce more breakage by moving to java.time.Instant as well.

@lhazlewood
Copy link
Contributor Author

lhazlewood commented Sep 9, 2019

For all sorts of good reasons, JJWT strictly adheres to Semantic Versioning.
This means you cannot introduce backwards-incompatible language features into minor or point releases. So, Java 8 language features and classes/interfaces are not usable until we can increment a major version number, i.e. JJWT 1.0 or later.

1.0 will not be released until we finish JSON Web Encryption #279 . That will probably be in the last minor release (e.g. 0.11 or 0.12 or whatever). Immediately after JWE is done, we'll migrate to the Java 8 language features and classes, and that will constitute the first 1.0 release.

@lhazlewood lhazlewood added the jdk8 Changes related to migrating to JDK8 API features label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jdk8 Changes related to migrating to JDK8 API features
Projects
None yet
Development

No branches or pull requests

2 participants