Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequireIssuer checks multiple issuers #604

Closed
oussamaachech opened this issue Jun 24, 2020 · 7 comments
Closed

RequireIssuer checks multiple issuers #604

oussamaachech opened this issue Jun 24, 2020 · 7 comments
Labels
stale Stale issues pending deletion due to inactivity

Comments

@oussamaachech
Copy link

It would be nice if the JwtParserBuilder requireIssuer can accept an array of issuer Strings in order to check if the 'iss' from the parsed jwt token matches one of these issuers.

@lhazlewood
Copy link
Contributor

This should be completed as part of #336

@stale stale bot added the stale Stale issues pending deletion due to inactivity label Sep 10, 2020
@lhazlewood lhazlewood removed the stale Stale issues pending deletion due to inactivity label Sep 10, 2020
@jwtk jwtk deleted a comment from stale bot Sep 10, 2020
@stale
Copy link

stale bot commented Nov 9, 2020

This issue has been automatically marked as stale due to inactivity for 60 or more days. It will be closed in 7 days if no further activity occurs.

@stale stale bot added the stale Stale issues pending deletion due to inactivity label Nov 9, 2020
@stale
Copy link

stale bot commented Nov 21, 2020

Closed due to inactivity.

@stale stale bot closed this as completed Nov 21, 2020
@lhazlewood lhazlewood reopened this Nov 21, 2020
@stale stale bot removed the stale Stale issues pending deletion due to inactivity label Nov 21, 2020
@ars-java
Copy link

Is anybody implementing it? If not I can take this issue.

@stale stale bot added the stale Stale issues pending deletion due to inactivity label Jan 30, 2021
@stale stale bot closed this as completed Feb 7, 2021
@jwtk jwtk deleted a comment from stale bot Feb 17, 2021
@jwtk jwtk deleted a comment from stale bot Feb 17, 2021
@lhazlewood lhazlewood removed duplicate stale Stale issues pending deletion due to inactivity labels Feb 17, 2021
@lhazlewood
Copy link
Contributor

Reopening. However, we're introducing a new validation framework for 1.0, so the implementation of this will be dependent upon that, so please no pull requests for this feature just yet - until that is finished.

@lhazlewood lhazlewood reopened this Feb 17, 2021
@stale stale bot added the stale Stale issues pending deletion due to inactivity label Jun 2, 2021
@bdemers bdemers removed the stale Stale issues pending deletion due to inactivity label Jun 2, 2021
@jwtk jwtk deleted a comment from stale bot Jun 2, 2021
@stale stale bot added the stale Stale issues pending deletion due to inactivity label Aug 4, 2021
@jwtk jwtk deleted a comment from stale bot Aug 4, 2021
@stale stale bot removed the stale Stale issues pending deletion due to inactivity label Aug 4, 2021
@stale stale bot added the stale Stale issues pending deletion due to inactivity label Apr 16, 2022
@bdemers bdemers removed the stale Stale issues pending deletion due to inactivity label Apr 18, 2022
@jwtk jwtk deleted a comment from stale bot Apr 20, 2022
@stale
Copy link

stale bot commented Jul 10, 2022

This issue has been automatically marked as stale due to inactivity for 60 or more days. It will be closed in 7 days if no further activity occurs.

@stale stale bot added the stale Stale issues pending deletion due to inactivity label Jul 10, 2022
@lhazlewood
Copy link
Contributor

Closing this in favor of #474 . The require* methods were too numerous and didn't do nearly enough, but #474 will allow an entire range of validations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale issues pending deletion due to inactivity
Projects
None yet
Development

No branches or pull requests

4 participants