[#719] JSON-B extension. #720
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdemers
reviewed
Apr 18, 2022
Comment on lines
1285
to
1286
| **If you want to use POJOs as claim values, use either the `io.jsonwebtoken:jjwt-jackson` or | ||
| `io.jsonwebtoken:jjwt-gson` dependency** (or implement your own Serializer and Deserializer if desired). **But beware**, |
There was a problem hiding this comment.
Suggested change
| **If you want to use POJOs as claim values, use either the `io.jsonwebtoken:jjwt-jackson` or | |
| `io.jsonwebtoken:jjwt-gson` dependency** (or implement your own Serializer and Deserializer if desired). **But beware**, | |
| **If you want to use POJOs as claim values, use either the `io.jsonwebtoken:jjwt-jackson`, `io.jsonwebtoken:jjwt-jsonb`, or | |
| `io.jsonwebtoken:jjwt-gson` dependency** (or implement your own Serializer and Deserializer if desired). **But beware**, |
There was a problem hiding this comment.
Uhm, you were changing a line which I didn’t touch. Did you mean to do that?
I did not implement the Map constructor for jsonb (nor did any of you for gson)...
bdemers
reviewed
Apr 18, 2022
bdemers
reviewed
Apr 18, 2022
extensions/jsonb/src/main/java/io/jsonwebtoken/jsonb/io/JsonbDeserializer.java
Outdated
Show resolved
Hide resolved
bdemers
reviewed
Apr 18, 2022
extensions/jsonb/src/main/java/io/jsonwebtoken/jsonb/io/JsonbSerializer.java
Outdated
Show resolved
Hide resolved
bdemers
reviewed
Apr 18, 2022
|
Great work! |
|
Oh, shouldn’t the profile name be "nonJDK7"? And did I, by accident, not rebase the PR? |
|
good point, java8plus, nonJDK7 or something like that would work |
Nah you already have "nonJDK7" in your root- |
bmarwell
force-pushed
the
719_jsonb_extension
branch
from
22ec763
to
cb1f42e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #719:
This commit will add a JSON-B extension based on JSON-B specification 1.0.2.
Noteworthy
jdk.versionwas set to8.nullinput is validated byjava.util.Objcets.requireNonNulland will throw aNullPointerException(which makes more sense anyway) instead of anIllegalArgumentException.Strings.UTF_8the JDK8-includedStandardCharsets.UTF_8was used.intergation-tests/json/jsonb-yassonandintergation-tests/json/jsonb-sth-else).provided) dependency on json-api (aka json-p for JSON-Parser) is needed at least for Johnzon, but probably for some Exceptions as well. Johnzon fails becausejavax.json.JsonExceptionis missing. But since json-api/json-p is a transitive dependency for json-bind-api (json-b) as well, this should be okay.Other notes
providedscope is because of JakarteEE Application Server usage. Tested on OpenLiberty. But for JavaSE apps, users of this lib would need to include those by hand, as well as the implementation. This should go into the README.Tasks