Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show table comments for related tables of View. #587

Closed
majimaccho opened this issue May 24, 2024 · 2 comments
Closed

Show table comments for related tables of View. #587

majimaccho opened this issue May 24, 2024 · 2 comments
Labels

Comments

@majimaccho
Copy link
Contributor

Hi. I'm always thankful for this great library tbls!

I have an idea it could improve user experience about View thing.

Currently view's Referenced Tables section is looking like below.

## Referenced Tables

- [shema.table_name](shema.table_name.md)

I suppose it could be better to show table in format of other sections showing tables like below.

## Referenced Tables

| name | columns |  comments | type | 
| --- | --- | --- | --- |
| {name} | {columns} |  {comments} | {type} | 

Let me know, what you think.
Thank you! ;)

@majimaccho majimaccho added the enhancement New feature or request label May 24, 2024
@k1LoW
Copy link
Owner

k1LoW commented May 24, 2024

Hi @majimaccho!

Looks good.

If adopted, the Related Tables section might be better placed below the Columns section.
This is because there will be more information in the Related Tables section.

@majimaccho
Copy link
Contributor Author

Thanks! I'll work on this.

If adopted, the Related Tables section might be better placed below the Columns section.
This is because there will be more information in the Related Tables section.

I got this point 👍

k1LoW added a commit that referenced this issue Jun 4, 2024
Show table comments for related tables of View (#587)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants