New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconciler not reporting the actual failure when it fails to reconcile overlapping IP addresses #396

Open

dougbtv opened this issue Dec 11, 2023 · 0 comments

Member

dougbtv commented Dec 11, 2023

We output the error here:

whereabouts/pkg/reconciler/iploop.go

Line 254 in 0d7d2be

    
           return logging.Errorf("could not reconcile cluster wide IPs: %v", failedReconciledClusterWideIPs)

But... we don't actually report the error that happens here @ https://github.com/k8snetworkplumbingwg/whereabouts/blob/0d7d2be59005359f33ec2d67b0ab004f9c59f291/pkg/reconciler/iploop.go#L245C3-L246

We need to output the k8s error and not just the IP address that errored out, it makes this difficult to debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment