feat: append imagePullSecrets to injected pods to support private registries #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonatankahana
added
area/injection
Codecov ReportBase: 72.07% // Head: 73.22% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 72.07% 73.22% +1.15%
==========================================
Files 5 5
Lines 709 747 +38
==========================================
+ Hits 511 547 +36
- Misses 164 166 +2
Partials 34 34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
As a note, we use https://github.com/titansoft-pte-ltd/imagepullsecret-patcher across our cluster so that everything gets our private registry imagepullsecret automatically injected into the deployments. K8TZ doesn't really have to do this, but if it does get added, I could have this injector do both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main problem here is that the secret may (and probably will) not be available in every namespace and not in the same name always. So I am still wondering if this is the right approach or the user should do it manually. Maybe it should be optional and not enabled by default(?). Maybe configurable with some annotations?
TODO:
Close #49