Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8tz initContainer does not pick up the compute resources from values.yaml #83

Closed
feizhe1996 opened this issue Sep 13, 2023 · 2 comments
Closed

k8tz initContainer does not pick up the compute resources from values.yaml #83

feizhe1996 opened this issue Sep 13, 2023 · 2 comments
Labels
area/injection Patch Injections area bug Something isn't working good first issue Good for newcomers

Comments

@feizhe1996
Copy link
Contributor

feizhe1996 commented Sep 13, 2023 •
edited

When the namespace is guarded by a resource quota, each container needs to specify the resource requirement.
I found that the initContainer launched by the k8tz webhook does not pick up the compute resources from values.yaml.
It seems that the compute resource only gets applied to the webhook controller pod.

This leads to k8s throwing quota errors:
Error creating: pods "xxxx" is forbidden: failed quota: compute-resources: must specify requests.cpu for: k8tz; requests.memory for: k8tz
@yonatankahana yonatankahana added bug Something isn't working good first issue Good for newcomers area/injection Patch Injections area labels Sep 13, 2023
feizhe1996 added a commit to feizhe1996/k8tz that referenced this issue Sep 19, 2023
@feizhe1996
Patch the init container with compute resources
5445b45 
Fix for k8tz#83.
When the namespace is guarded by a resource quota, each container
needs to specify the resource requirement. Previously, the compute
resources specified in values.yaml does not get passed down to
the initContainer specs.
Since the resources definition is a multi-line string block, the
fix tries to pass a json formatted string as an argument to the
cli.
feizhe1996 added a commit to feizhe1996/k8tz that referenced this issue Sep 19, 2023
@feizhe1996
Patch the init container with compute resources
504430c 
Fix for k8tz#83.
Previously, the compute resources specified in values.yaml
did not get passed down to the initContainer specs.
When the namespace is guarded by a resource quota, each container
needs to specify the resource requirement, otherwise, k8s throws
quota errors.

Since the resources definition is a multi-line string block, the
fix tries to pass a json formatted string as an argument to the
cli.
@feizhe1996 feizhe1996 mentioned this issue Sep 19, 2023
Merged
@Sebastian-RG
Copy link

This affects me. Thank you for your PR! Hope it gets merged soon!

feizhe1996 added a commit to feizhe1996/k8tz that referenced this issue Apr 23, 2024
@feizhe1996
Patch the init container with compute resources
14f4999 
Fix for k8tz#83.
Previously, the compute resources specified in values.yaml did not get passed down to the initContainer specs. When the namespace is guarded by a resource quota, each container needs to specify the resource requirement, otherwise, k8s throws quota errors.

Since the resources definition is a multi-line string block, the fix tries to pass a json formatted string as an argument to the cli.
feizhe1996 added a commit to feizhe1996/k8tz that referenced this issue Apr 23, 2024
@feizhe1996
Patch the init container with compute resources
e8125ab 
Fix for k8tz#83.
Previously, the compute resources specified in values.yaml did not get passed down to the initContainer specs. When the namespace is guarded by a resource quota, each container needs to specify the resource requirement, otherwise, k8s throws quota errors.

Since the resources definition is a multi-line string block, the fix tries to pass a json formatted string as an argument to the cli.
feizhe1996 added a commit to feizhe1996/k8tz that referenced this issue Apr 23, 2024
@feizhe1996
Patch the init container with compute resources
bdf5805 
Fix for k8tz#83.
Previously, the compute resources specified in values.yaml did not get passed down to the initContainer specs. When the namespace is guarded by a resource quota, each container needs to specify the resource requirement, otherwise, k8s throws quota errors.

Since the resources definition is a multi-line string block, the fix tries to pass a json formatted string as an argument to the cli.
feizhe1996 added a commit to feizhe1996/k8tz that referenced this issue Apr 23, 2024
@feizhe1996
Patch the init container with compute resources
31b9d48 
Fix for k8tz#83.
Previously, the compute resources specified in values.yaml did not get passed down to the initContainer specs. When the namespace is guarded by a resource quota, each container needs to specify the resource requirement, otherwise, k8s throws quota errors.

Since the resources definition is a multi-line string block, the fix tries to pass a json formatted string as an argument to the cli.
feizhe1996 added a commit to feizhe1996/k8tz that referenced this issue Apr 23, 2024
@feizhe1996
Patch the init container with compute resources
0e4a7a4 
Fix for k8tz#83.
Previously, the compute resources specified in values.yaml did not get passed down to the initContainer specs. When the namespace is guarded by a resource quota, each container needs to specify the resource requirement, otherwise, k8s throws quota errors.

Since the resources definition is a multi-line string block, the fix tries to pass a json formatted string as an argument to the cli.
@yonatankahana
Copy link
Member

fixed in #85 and released in v0.16.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/injection Patch Injections area bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yonatankahana @feizhe1996 @Sebastian-RG