Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-03-05 - GitHub action の JavaScript action で node の major を上げた時に action 自体の major version も上げるべきなのかどうなのか #270

Closed
kachick opened this issue Mar 5, 2024 · 1 comment
Labels
blog question Further information is requested

Comments

@kachick
Copy link
Owner

kachick commented Mar 5, 2024

公式のアクションが今までnodeに伴いmajor上げてたからほーんそういうもんかとなんとなくそう思い込んでたけど、突っ込んでる人もいてやはり・・・どっちなんだ!?となった。

actions/checkout#1436 (comment)
https://github.com/actions/upload-artifact/releases/tag/v3.0.0

というのがふと気になったのは、podman というか buildah で container image を build する action が node 上げたんだけど minor up だったから

redhat-actions/buildah-build#128 (comment)

action ui の warning からは https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ に誘導されるが、特にそのあたりは言及されてない

@kachick kachick added question Further information is requested blog labels Mar 5, 2024
@kachick kachick closed this as completed Mar 5, 2024
kachick added a commit to kachick/dotfiles that referenced this issue Mar 6, 2024
push-to-registry does not release tags yet, but only build phase change is enough for updating runner I think

And I specify their non major versions kachick/times_kachick#270
@kachick
Copy link
Owner Author

kachick commented Mar 25, 2024

https://github.com/dependabot/fetch-metadata/releases/tag/v2.0.0

これもそんな感じで上げてきてて、GitHub の公式というかに近いものほどそうしているっぽいけどあんま妥当性を感じないというか自分が理解できてない気がする

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant