Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@kadena/client] Compatibility (layer) #151

Open
nillo opened this issue Jan 27, 2023 · 2 comments
Open

[@kadena/client] Compatibility (layer) #151

nillo opened this issue Jan 27, 2023 · 2 comments
Labels
enhancement New feature or request no-issue-activity

Comments

@nillo
Copy link
Contributor

nillo commented Jan 27, 2023

Is your feature request related to a problem? Please describe.

Compatibility: Kadena client currently does not conform Pact.lang.api
Functionality Some enforced functionality should be optional

suggestion:
-- un- deprecate pact-lang-api until compatibility layer has been provided

Describe the solution you'd like
Compatibility:

Currently the major wallets make use of the pact-lang-api but kadena client only support signing with chainweaver (quicksign) in order to enforce current project to make use of kadena.js a adaptor should be provided ensure the backwards compatibility of the project. This adaptor is a separate later ensuring the cleanness of kadena client.

Functionality:
Kadena client enforces decimals when typeof x === 'number' this is okay for coin.TRANSFER but assumably not for other functions were you might want to provide for example an integer.

Additional context
I will extend this thread with other findings if needed.

@nillo nillo added the enhancement New feature or request label Jan 27, 2023
@nillo nillo changed the title @kadena/client] Compatibility (layer) [@kadena/client] Compatibility (layer) Jan 27, 2023
@Randynamic
Copy link
Contributor

Yes Had a great discussion with the team and until we fixed that part we undeprecate pact-lang-api

@github-actions
Copy link
Contributor

This issue is stale because it is open for 60 days with no activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no-issue-activity
Projects
None yet
Development

No branches or pull requests

2 participants