Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give a way to retrieve the account from eckoWallet #1613

Open
2 of 3 tasks
CryptoPascal31 opened this issue Feb 9, 2024 · 1 comment · May be fixed by #1688
Open
2 of 3 tasks

Give a way to retrieve the account from eckoWallet #1613

CryptoPascal31 opened this issue Feb 9, 2024 · 1 comment · May be fixed by #1688
Labels
enhancement New feature or request no-issue-activity

Comments

@CryptoPascal31
Copy link

Please confirm the following:

Is your feature request related to a problem?

While eckoWallet gives an API to retrieve the account of the connected wallet, Kadena-JS doesn't wrap it and doesn't give any standard way to retrieve it.
IMO, this is a very important use case… that should be handled by Kadena-JS client.

For example, in my frontend I had to add a small and ugly workaround:

https://github.com/Marmalade-NG/marmalade-ng-explorer/blob/06ee5e2dd82b2351abcd88a2e57916395009d62a/src/Buying.jsx#L21

Instead of using 100% the kadena-JS abstraction.

Describe the solution you'd like

I would propose to add a new "side function" in the eckoWallet module:
I don't know exactly how should look like the API..

quicksignWithEckoWallet.isInstalled = isInstalled;

Describe alternatives you've considered

No response

Do you have any additional context?

No response

Participation

  • I am willing to submit a pull request for this feature request.
@CryptoPascal31 CryptoPascal31 added the enhancement New feature or request label Feb 9, 2024
@ash-vd ash-vd linked a pull request Feb 20, 2024 that will close this issue
Copy link
Contributor

github-actions bot commented Apr 9, 2024

This issue is stale because it is open for 60 days with no activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no-issue-activity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant