Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checkStatus to Ecko signing functions #1688

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add checkStatus to Ecko signing functions #1688

wants to merge 1 commit into from

Conversation

ash-vd
Copy link
Member

@ash-vd ash-vd commented Feb 20, 2024 •
edited

Adds a wrapper around the kda_checkStatus function from Ecko Wallet, which returns the currently connected account.

Closes #1613

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2024 •
edited

⚠️ No Changeset found

Latest commit: 0309008

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 20, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
alpha-docs ✅ Ready (Inspect) Visit Preview Feb 20, 2024 6:50pm
proof-of-us ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 6:50pm
react-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 6:50pm
tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 6:50pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2024 6:50pm

alber70g
alber70g approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@alber70g alber70g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for later: we need to add documentation for the various signWith-methods to the readme

@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it is open for 60 days with no activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alber70g alber70g alber70g approved these changes

@javadkh2 javadkh2 Awaiting requested review from javadkh2 javadkh2 is a code owner

@nillo nillo Awaiting requested review from nillo nillo is a code owner

Assignees
No one assigned
Labels
no-pr-activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Give a way to retrieve the account from eckoWallet
2 participants
@ash-vd @alber70g