Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested links in main nav bar? #1713

Open
goroderickgo opened this issue Feb 20, 2024 · 2 comments
Open

Nested links in main nav bar? #1713

goroderickgo opened this issue Feb 20, 2024 · 2 comments

Comments

@goroderickgo
Copy link

Hi, I was wondering you had a sense of how difficult it would be to implement nested links in the main nav bar? Seems like the current implementation doesn't allow for that:

main_nav_links = {
key: value for key, value in extra_links.items() if isinstance(value, str)
}

I saw that feature in a different theme: https://shibuya.lepture.com/customisation/navbar/#nested-links

@kai687
Copy link
Owner

kai687 commented Feb 21, 2024

That's a nice theme! Since I don't know what your previous experience is, it's hard for me to tell. The code is open source, so you can take a look! The devil is in the detail though. For example, the expandable menu on the Shibuya theme isn't navigable by keyboard.

Personally, I don't have any use for this, so I don't plan to add this anytime soon. Contributions welcome, though!

@goroderickgo
Copy link
Author

goroderickgo commented Feb 21, 2024

I have exactly 0 web dev experience so have been wandering around in the dark, but I will poke around when I have time 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants