Python: add compatibility layer for Python 2 & <=3.11 #115
Conversation
Mingun
changed the title
Mingun
force-pushed
the
fix-python-3.12-tests
branch
from
4875b4c
to
2e117fa
Compare
spec/python/test_eof_exception_u4.py
Outdated
| # Python 2 has only assertRaisesRegexp method | ||
| # Python 3.11 and below have both assertRaisesRegex and assertRaisesRegexp | ||
| # Python 2.12 and above has only assertRaisesRegex | ||
| # The tests run on both Python 2 & 3, so we add missing method for compatibility | ||
| if not hasattr(unittest.TestCase, 'assertRaisesRegex'): | ||
| setattr(unittest.TestCase, 'assertRaisesRegex', unittest.TestCase.assertRaisesRegexp) |
There was a problem hiding this comment.
Sounds good, appreciate your fix here!
Do you think we can actually extract this into a separate file not to repeat these lines everywhere?
Something akin to helpers/javascript?
There was a problem hiding this comment.
I was thinking about building a base class for tests, but since I don't test it (I'm too lazy to set up all the language environments that will only be needed for one thing), I was not sure that this will work and I made the simplest solution.
Something like this, but I'm not sure if constructor should have some arguments:
class BaseTest(unittest.TestCase):
def __init__():
if not hasattr(unittest.TestCase, 'assertRaisesRegex'):
setattr(unittest.TestCase, 'assertRaisesRegex', unittest.TestCase.assertRaisesRegexp)
Mingun
force-pushed
the
fix-python-3.12-tests
branch
from
2e117fa
to
47fe558
Compare
|
Ok, I found a way to run python tests on Windows (7):
I implemented the check in a common file which was placed to the Running tests reports two classes of warnings, I've fix them too. |
Python 2 has only assertRaisesRegexp Python <=3.11 have both assertRaisesRegex and (deprecated) assertRaisesRegexp Python >=3.12 has only assertRaisesRegex
with self.assertRaisesRegex(EOFError, "^requested \d+ bytes, but only \d+ bytes available$"):
…e='rb' closefd=True>
where ... = src/fixed_struct.bin
= src/switch_opcodes.bin
Mingun
force-pushed
the
fix-python-3.12-tests
branch
from
47fe558
to
85d54b2
Compare
Use the non-deprecated method in Python 3 and fix tests in Python >=3.12:
assertRaisesRegexpassertRaisesRegexand (deprecated)assertRaisesRegexpassertRaisesRegexShould fix the following tests on https://ci.kaitai.io/
Closes kaitai-io/kaitai_struct#1104