Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construct: the order of Computed fields matter #1106

Open
Mingun opened this issue Apr 15, 2024 · 0 comments
Open

Construct: the order of Computed fields matter #1106

Mingun opened this issue Apr 15, 2024 · 0 comments

Comments

@Mingun
Copy link

Mingun commented Apr 15, 2024

Currently some tests on https://ci.kaitai.io/ are failed because of that fact that instance fields are sorted alphabetically (due to SortedMap used for storage) and generated in the same order.

Sorting of instances are good thing which will ensure stable output friendly for diffs, but Construct currently cannot calculate dependents inside of Computed fields and raises an error instead.

Although problem seems to be resolved on Construct side, it also could be useful to generate Computed properties in a topological order of dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant