From a664d7752d7b1a62c1a221050aa4563d1617f142 Mon Sep 17 00:00:00 2001 From: Karl von Randow Date: Tue, 13 Nov 2018 17:12:12 +1300 Subject: [PATCH] Fix mini-css-extract-plugin 0.4.3 issue Resolves https://github.com/danethurber/webpack-manifest-plugin/issues/167 mini-css-extract-plugin reports additional, incorrect information for files that are refenced in CSS. The first time we see the file the `module.userRequest` is correct, and we add to `moduleAssets` correctly. However mini-css-extract-plugin then also reports the same `file` but with `module.userRequest` set to the CSS file that references it, which caused us to overwrite the good value in `moduleAssets`. See the change in mini-css-extract-plugin that caused this https://github.com/webpack-contrib/mini-css-extract-plugin/pull/177 --- lib/plugin.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/plugin.js b/lib/plugin.js index 0dc9310..de17947 100644 --- a/lib/plugin.js +++ b/lib/plugin.js @@ -60,7 +60,7 @@ ManifestPlugin.prototype.apply = function(compiler) { var outputName = path.relative(outputFolder, outputFile); var moduleAsset = function (module, file) { - if (module.userRequest) { + if (module.userRequest && !moduleAssets[file]) { moduleAssets[file] = path.join( path.dirname(file), path.basename(module.userRequest)