Skip to content

Commit

Permalink
feat: no longer write json unless configured
Browse files Browse the repository at this point in the history
BREAKING CHANGE: No json coverage is generated by default. If you want that, please use `json` reporter:

```js
coverageReporter: {
  type: 'json'
}

// or with multiple reporters
coverageReporter: {
  reporters: [
    {type: 'html', dir: 'coverage'},
    {type: 'json', dir: 'coverage'},
  ]
}
```
  • Loading branch information
joseph-connolly authored and vojtajina committed Feb 14, 2014
1 parent 8319eff commit 1256fb8
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 31 deletions.
16 changes: 1 addition & 15 deletions lib/reporter.js
Expand Up @@ -88,20 +88,6 @@ var CoverageReporter = function(rootConfig, helper, logger) {
if (result && result.coverage) {
collector.add(result.coverage);
}

pendingFileWritings++;
helper.mkdirIfNotExists(outDir, function() {
var now = dateformat(new Date(), 'yyyymmdd_HHMMss');
var name = 'coverage-' + browser.name + '-' + now + '.json';
var filepath = path.join(outDir, name);
log.debug('Writing coverage to %s', filepath);
fs.writeFile(filepath, JSON.stringify(collector.getFinalCoverage()), 'utf8', function(err) {
if (err) {
log.error(err);
}
writeEnd();
});
});
};

this.onSpecComplete = function(browser, result) {
Expand All @@ -110,7 +96,7 @@ var CoverageReporter = function(rootConfig, helper, logger) {
}
};

this.onRunComplete = function(browsers, results) {
this.onRunComplete = function(browsers) {
reporters.forEach(function(reporterConfig) {
browsers.forEach(function(browser) {
var collector = collectors[browser.id];
Expand Down
16 changes: 0 additions & 16 deletions test/reporter.spec.coffee
Expand Up @@ -122,7 +122,6 @@ describe 'reporter', ->
browsers.add fakeOpera
reporter.onRunStart()
browsers.forEach (b) -> reporter.onBrowserStart b
mockFs.writeFile.reset()
mockMkdir.reset()

it 'has no pending file writings', ->
Expand All @@ -140,21 +139,6 @@ describe 'reporter', ->
reporter.onBrowserComplete fakeChrome, undefined
expect(mockAdd).not.to.have.been.called

it 'should store coverage json', ->
result =
coverage:
aaa: 1
bbb: 2
reporter.onBrowserComplete fakeChrome, result
expect(mockAdd).to.have.been.calledWith result.coverage
expect(mockMkdir).to.have.been.called
args = mockMkdir.lastCall.args
expect(args[0]).to.deep.equal path.resolve('/base', rootConfig.coverageReporter.dir)
args[1]()
expect(mockFs.writeFile).to.have.been.calledWith
args2 = mockFs.writeFile.lastCall.args
# expect(args2[1]).to.deep.equal JSON.stringify(result.coverage)

it 'should make reports', ->
reporter.onRunComplete browsers
expect(mockMkdir).to.have.been.calledTwice
Expand Down

0 comments on commit 1256fb8

Please sign in to comment.