From 1256fb8b56ca6317314619a918610a322eb4fe27 Mon Sep 17 00:00:00 2001
From: Joseph Connolly <joec@avinetworks.com>
Date: Thu, 26 Dec 2013 21:55:12 -0800
Subject: [PATCH] feat: no longer write json unless configured

BREAKING CHANGE: No json coverage is generated by default. If you want that, please use `json` reporter:

```js
coverageReporter: {
  type: 'json'
}

// or with multiple reporters
coverageReporter: {
  reporters: [
    {type: 'html', dir: 'coverage'},
    {type: 'json', dir: 'coverage'},
  ]
}
```
---
 lib/reporter.js           | 16 +---------------
 test/reporter.spec.coffee | 16 ----------------
 2 files changed, 1 insertion(+), 31 deletions(-)

diff --git a/lib/reporter.js b/lib/reporter.js
index 8f73e8a..d08fa0e 100644
--- a/lib/reporter.js
+++ b/lib/reporter.js
@@ -88,20 +88,6 @@ var CoverageReporter = function(rootConfig, helper, logger) {
     if (result && result.coverage) {
       collector.add(result.coverage);
     }
-
-    pendingFileWritings++;
-    helper.mkdirIfNotExists(outDir, function() {
-      var now = dateformat(new Date(), 'yyyymmdd_HHMMss');
-      var name = 'coverage-' + browser.name + '-' + now + '.json';
-      var filepath = path.join(outDir, name);
-      log.debug('Writing coverage to %s', filepath);
-      fs.writeFile(filepath, JSON.stringify(collector.getFinalCoverage()), 'utf8', function(err) {
-        if (err) {
-          log.error(err);
-        }
-        writeEnd();
-      });
-    });
   };
 
   this.onSpecComplete = function(browser, result) {
@@ -110,7 +96,7 @@ var CoverageReporter = function(rootConfig, helper, logger) {
     }
   };
 
-  this.onRunComplete = function(browsers, results) {
+  this.onRunComplete = function(browsers) {
     reporters.forEach(function(reporterConfig) {
       browsers.forEach(function(browser) {
         var collector = collectors[browser.id];
diff --git a/test/reporter.spec.coffee b/test/reporter.spec.coffee
index 335a240..1f9783c 100644
--- a/test/reporter.spec.coffee
+++ b/test/reporter.spec.coffee
@@ -122,7 +122,6 @@ describe 'reporter', ->
       browsers.add fakeOpera
       reporter.onRunStart()
       browsers.forEach (b) -> reporter.onBrowserStart b
-      mockFs.writeFile.reset()
       mockMkdir.reset()
 
     it 'has no pending file writings', ->
@@ -140,21 +139,6 @@ describe 'reporter', ->
       reporter.onBrowserComplete fakeChrome, undefined
       expect(mockAdd).not.to.have.been.called
 
-    it 'should store coverage json', ->
-      result =
-        coverage:
-          aaa: 1
-          bbb: 2
-      reporter.onBrowserComplete fakeChrome, result
-      expect(mockAdd).to.have.been.calledWith result.coverage
-      expect(mockMkdir).to.have.been.called
-      args = mockMkdir.lastCall.args
-      expect(args[0]).to.deep.equal path.resolve('/base', rootConfig.coverageReporter.dir)
-      args[1]()
-      expect(mockFs.writeFile).to.have.been.calledWith
-      args2 = mockFs.writeFile.lastCall.args
-      # expect(args2[1]).to.deep.equal JSON.stringify(result.coverage)
-
     it 'should make reports', ->
       reporter.onRunComplete browsers
       expect(mockMkdir).to.have.been.calledTwice