Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_.contains function doesn't work with lodash 4.3.0 #210

Closed
EdIzotov opened this issue Feb 11, 2016 · 4 comments
Closed

_.contains function doesn't work with lodash 4.3.0 #210

EdIzotov opened this issue Feb 11, 2016 · 4 comments

Comments

@EdIzotov
Copy link

There is _.contains function is used In preprocessor.js file. But the function was renamed in 4.3.0 lodash version to _.includes.

Error I get:

[2016-02-11 14:57:02.872] [WARN] preprocess - Can not load "coverage"!
TypeError: _.contains is not a function
at createCoveragePreprocessor (MyProject\node_modules\kar
ma-coverage\lib\preprocessor.js:53:10)
at Array.invoke (MyProject\node_modules\karma\node_module
s\di\lib\injector.js:75:15)
at get (MyProject\node_modules\karma\node_modules\di\lib
injector.js:48:43)
at instantiatePreprocessor (MyProject\node_modules\karma
lib\preprocessor.js:33:20)
at Array.forEach (native)
at MyProject\node_modules\karma\lib\preprocessor.js:49:21

@britztopher
Copy link

+1 @EdIzotov it wouldnt be a tough pull request if you did it yourself. If you are, update it to 4.5 though

@dwatling
Copy link
Contributor

I've added a pull request to fix this issue. #212

@britztopher
Copy link

thanks @dwatling

@patrickkettner
Copy link

@karma-runner this can be closed, since #212 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants