Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "update-contributors" step in CI/CD fails #458

Open
jginsburgn opened this issue Dec 1, 2021 · 0 comments
Open

The "update-contributors" step in CI/CD fails #458

jginsburgn opened this issue Dec 1, 2021 · 0 comments

Comments

@jginsburgn
Copy link
Member

We get the following output:

> karma-coverage@2.0.1 update-contributors
> grunt contributors

Running "npm-contributors" task
>> Cannot commit contributors changes:
>>   Author identity unknown
>> 
>> * Please tell me who you are.
>> 
>> Run
>> 
>>   git config --global user.email "you@example.com"
>>   git config --global user.name "Your Name"
>> 
>> to set your account's default identity.
>> Omit --global to set the identity only in this repository.
>> 
>> fatal: empty ident name (for <runner@fv-az121-790.yqyg1jmbfiaufnvoyh414x3y0b.phxx.internal.cloudapp.net>) not allowed

Corresponding to https://github.com/vojtajina/grunt-npm/blob/master/tasks/npm.js#L104-L106. It appears that although the grunt task shows as failed, the contributors update in package.json takes place because the changes are committed later by semantic-release-bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant